Remove configure_inline_support function #12814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a circular dependency between ipykernel and IPython.
|
This is backward incompatible for ipykernel. |
|
This conflict with master for whitespaces. |
|
Yep I guess this could be good. I will apply this and rebase. |
|
I am closing this PR. This cleanup is done in #12817. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a circular dependency between ipykernel and IPython.
This PR is coupled with another PR in ipykernel adding the function there: ipython/ipykernel#590
It goes in the direction of cleaning the ipykernel/IPython/matplotlib relationship, see ipython/ipykernel#588