Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Backport PR #12207 on branch 7.x (Bump jedi to at least 0.16.0 and fix deprecated function usage)" #12525

Merged
merged 1 commit into from Aug 29, 2020
Merged

Revert "Backport PR #12207 on branch 7.x (Bump jedi to at least 0.16.0 and fix deprecated function usage)" #12525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions IPython/core/completer.py
View file
Open in desktop
Expand Up @@ -988,8 +988,7 @@ def _make_signature(completion)-> str:

"""

return '(%s)'% ', '.join([f for f in (_formatparamchildren(p) for signature in completion.get_signatures()
for p in signature.defined_names()) if f])
return '(%s)'% ', '.join([f for f in (_formatparamchildren(p) for p in completion.params) if f])

class IPCompleter(Completer):
"""Extension of the completer class with IPython-specific features"""
Expand Down Expand Up @@ -1399,7 +1398,7 @@ def _jedi_matches(self, cursor_column:int, cursor_line:int, text:str):
if not try_jedi:
return []
try:
return filter(completion_filter, interpreter.complete())
return filter(completion_filter, interpreter.completions())
except Exception as e:
if self.debug:
return [_FakeJediCompletion('Oops Jedi has crashed, please report a bug with the following:\n"""\n%s\ns"""' % (e))]
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -187,7 +187,7 @@

install_requires = [
'setuptools>=18.5',
'jedi>=0.16',
'jedi>=0.10',
'decorator',
'pickleshare',
'traitlets>=4.2',
Expand Down