Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12218

gorogoroumaru · 2020-04-03T01:37:57Z

with jedi 0.17.0

In [1]: import warnings
In [2]: warnings.filters.remove(('ignore', None, DeprecationWarning, None, 0))
In [3]: a=0
In [4]: a.<TAB>

throws a deprecation warning below

DeprecationWarning: Providing the column is now done in the functions themselves like Script(...).complete(line, column)

So, I fixed it.

…unctions themselves like `Script(...).complete(line, column)`

LucianaMarques

Thanks for the PR! It's just now clear to me why your changes fixed the problem. Could you please give us some running examples?

(I'm unable at this moment to run the project, so that would help me)

LucianaMarques · 2020-04-06T21:57:57Z

IPython/core/completer.py

        try_jedi = True

        try:
            # find the first token in the current tree -- if it is a ' or " then we are in a string
            completing_string = False
            try:
-                first_child = next(c for c in interpreter._get_module().tree_node.children if hasattr(c, 'value'))
+                first_child = next(c for c in script._get_module().tree_node.children if hasattr(c, 'value'))


If you keep interpreter you don't have to change the following lines.

LucianaMarques · 2020-04-06T22:00:02Z

IPython/core/completer.py

@@ -1371,15 +1371,14 @@ def _jedi_matches(self, cursor_column:int, cursor_line:int, text:str):
                else:
                    raise ValueError("Don't understand self.omit__names == {}".format(self.omit__names))

-        interpreter = jedi.Interpreter(
-            text[:offset], namespaces, column=cursor_column, line=cursor_line + 1)
+        script = jedi.Interpreter(text[:offset],namespaces)


Why did you change the name here from interpreter to script?

Sorry, it’s my mistake.
I will fix it.

When I changed the variable name to “interpreter”, some checks were not successful.
Why?

Thanks for the change!

About the errors, I don't know why but you can check the tests results by clicking on details right next to them. I will try to take a look with it too tomorrow!

Which is your local python version? On one of the failed checks, there is the following message:

Extension error: Could not import extension configtraits (exception: cannot import name 'l_' from 'sphinx.locale' (/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/sphinx/locale/__init__.py)) Makefile:66: recipe for target 'html' failed make: *** [html] Error 2 make: Leaving directory '/home/travis/build/ipython/ipython/docs' The command "if [[ "$TRAVIS_PYTHON_VERSION" == "3.7" ]] && [[ "$TRAVIS_OS_NAME" == "linux" ]]; then pip install -r docs/requirements.txt python tools/fixup_whats_new_pr.py make -C docs/ html SPHINXOPTS="-W" fi " exited with 2.

Anaconda python3.7.7 is my local python version.
But why my local python version affects travis-CI checks?

…unctions themselves like `Script(...).complete(line, column)`

gorogoroumaru · 2020-04-07T00:05:52Z

Running Examples

IPython 8.0.0.dev

[before]

In [1]: import jedi

In [2]: jedi.__version__
Out[2]: '0.17.0'

In [3]: import warnings

In [4]: warnings.filters.remove(('ignore', None, DeprecationWarning, None, 0))

In [5]: a=0

In [6]: a.<tab>
\Anaconda3\envs\jedi\lib\site-packages\jedi-0.17.0-py3.8.egg\jedi\api\__init__.py:841: DeprecationWarning: Providing the line is now done in the functions themselves like `Script(...).complete(line, column)`
  super(Interpreter, self).__init__(code, environment=environment,
\Anaconda3\envs\jedi\lib\site-packages\jedi-0.17.0-py3.8.egg\jedi\api\__init__.py:841: DeprecationWarning: Providing the column is now done in the functions themselves like `Script(...).complete(line, column)`
  super(Interpreter, self).__init__(code, environment=environment,

[after]

In [1]: import jedi

In [2]: jedi.__version__
Out[2]: '0.17.0'

In [3]: import warnings

In [4]: warnings.filters.remove(('ignore', None, DeprecationWarning, None, 0))

In [5]: a=0

In [6]: a.<tab>

No Warnings

…unctions themselves like `Script(...).complete(line, column)`

gorogoroumaru · 2020-04-10T02:03:08Z

I couldn't pass the travis-ci checks, so I closed this PR and created another PR #12227.

gorogoroumaru added 3 commits April 3, 2020 10:24

Fixed the DeprecationWarning: Providing the line is now done in the f…

fcef06c

…unctions themselves like `Script(...).complete(line, column)`

Fixed the DeprecationWarning: Providing the line is now done in the f…

85de90e

…unctions themselves like `Script(...).complete(line, column)`

Fixed the DeprecationWarning: Providing the line is now done in the f…

ec0642c

…unctions themselves like `Script(...).complete(line, column)`

LucianaMarques reviewed Apr 6, 2020

View reviewed changes

LucianaMarques mentioned this pull request Apr 6, 2020

Deprecation warning on autocompletion with jedi 0.16 #12206

Closed

Fixed the DeprecationWarning: Providing the line is now done in the f…

c84738e

…unctions themselves like `Script(...).complete(line, column)`

gorogoroumaru added 4 commits April 7, 2020 09:47

Fixed the DeprecationWarning: Providing the line is now done in the f…

66d5003

…unctions themselves like `Script(...).complete(line, column)`

Merge remote-tracking branch 'origin/work' into work

8b43745

Merge remote-tracking branch 'origin/work' into work

8590530

Merge remote-tracking branch 'origin/work' into work

ecc5302

gorogoroumaru mentioned this pull request Apr 7, 2020

Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12222

Closed

gorogoroumaru closed this Apr 10, 2020

Carreau added this to the no action milestone May 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12218

Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12218

gorogoroumaru commented Apr 3, 2020 •

edited

LucianaMarques left a comment

LucianaMarques Apr 6, 2020

LucianaMarques Apr 6, 2020

gorogoroumaru Apr 6, 2020

gorogoroumaru Apr 7, 2020

LucianaMarques Apr 7, 2020

LucianaMarques Apr 7, 2020

gorogoroumaru Apr 10, 2020 •

edited

gorogoroumaru commented Apr 7, 2020 •

edited

gorogoroumaru commented Apr 10, 2020 •

edited

Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12218

Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12218

Conversation

gorogoroumaru commented Apr 3, 2020 • edited

LucianaMarques left a comment

Choose a reason for hiding this comment

LucianaMarques Apr 6, 2020

Choose a reason for hiding this comment

LucianaMarques Apr 6, 2020

Choose a reason for hiding this comment

gorogoroumaru Apr 6, 2020

Choose a reason for hiding this comment

gorogoroumaru Apr 7, 2020

Choose a reason for hiding this comment

LucianaMarques Apr 7, 2020

Choose a reason for hiding this comment

LucianaMarques Apr 7, 2020

Choose a reason for hiding this comment

gorogoroumaru Apr 10, 2020 • edited

Choose a reason for hiding this comment

gorogoroumaru commented Apr 7, 2020 • edited

gorogoroumaru commented Apr 10, 2020 • edited

gorogoroumaru commented Apr 3, 2020 •

edited

gorogoroumaru Apr 10, 2020 •

edited

gorogoroumaru commented Apr 7, 2020 •

edited

gorogoroumaru commented Apr 10, 2020 •

edited