Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarning on autocompletion with jedi 0.17.0 #12227

Merged
merged 1 commit into from Apr 23, 2020

Conversation

gorogoroumaru
Copy link
Contributor

@gorogoroumaru gorogoroumaru commented Apr 10, 2020

with jedi 0.17.0

In [1]: import warnings
In [2]: warnings.filters.remove(('ignore', None, DeprecationWarning, None, 0))
In [3]: a=0
In [4]: a.<TAB>

throws a deprecation warning below

DeprecationWarning: Providing the column is now done in the functions themselves like Script(...).complete(line, column)

So, I fixed it.

@Carreau Carreau added this to the 8.0 milestone Apr 22, 2020
@Carreau
Copy link
Member

Carreau commented Apr 23, 2020

Thanks, I had to rebase on master to get the test to pass (they were failing for an unrelated reason).

@Carreau Carreau merged commit 0bb76dd into ipython:master Apr 23, 2020
Carreau pushed a commit to Carreau/ipython that referenced this pull request Jan 29, 2021
This is for Jedi 0.18 compatibility.

Fix DeprecationWarning on autocompletion with jedi 0.17.0
MrMino pushed a commit to MrMino/ipython that referenced this pull request Aug 31, 2021
This is for Jedi 0.18 compatibility.

Fix DeprecationWarning on autocompletion with jedi 0.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants