Bump jedi to at least 0.16.0 and fix deprecated function usage #12207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That sounds good ! Thanks ! |
|
would forcing support of jedi>=0.15.2 have been sufficient ? we're a bit stuck during the Spyder transition, as some fixes will only be in Jedi-0.17.1 |
Sorry I missed this question; I'll see in the backport if I can pin to only 0.15.2, but it's less than a month difference, so it won't change much I think. And so far this is only planned to be released in 8.0 which is not before fall I think. |
|
@meeseeksdev backport to 7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Aug 9, 2020
…cated function usage
and no .complete() is only 0.16.0+ |
Carreau
added a commit
that referenced
this pull request
Aug 27, 2020
…207-on-7.x Backport PR #12207 on branch 7.x (Bump jedi to at least 0.16.0 and fix deprecated function usage)
Carreau
added a commit
that referenced
this pull request
Aug 29, 2020
…0 and fix deprecated function usage)"
Carreau
added a commit
that referenced
this pull request
Aug 29, 2020
…pr-12207-on-7.x Revert "Backport PR #12207 on branch 7.x (Bump jedi to at least 0.16.0 and fix deprecated function usage)"
Carreau
pushed a commit
to Carreau/ipython
that referenced
this pull request
Jan 29, 2021
This should make jedi 0.18 compatible with 7.x. Pinning is not an option as the resolver is free to pick older IPython with jedi 0.18 -- Bump jedi to at least 0.16.0 and fix deprecated function usage
MrMino
pushed a commit
to MrMino/ipython
that referenced
this pull request
Aug 31, 2021
Full sha of original commit: 5e979ec This should make jedi 0.18 compatible with 7.x. Pinning is not an option as the resolver is free to pick older IPython with jedi 0.18 -- Bump jedi to at least 0.16.0 and fix deprecated function usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #12102
I ran
iptest IPython.core.tests.test_completerand it didn't seem to give any errors. Not sure if we want to add any new tests here, or if that is good enough.According to jedi,
Multiple signatures are typical if you use Python stubs with @overload.I made my change to account for all signatures, but not sure how this plays out IRL since I've never seen a function with multiple signatures.