Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import configure_inline_support from matplotlib_inline if available #653

Closed
wants to merge 1 commit into from

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented May 2, 2021

  • This correctly applies the rcParams declared in the inline backend configuration when using %matplotlib inline.
  • This is necessary for IPython 7.23+, which requires matplotlib_inline now.
  • I also think a new release in the 5.5 series is required to work with that IPython version.

Pinging @SylvainCorlay and @blink1073 about this one.

This correctly applies the rcParams declared in the inline backend
configuration when using "%matplotlib inline".
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 6.0 milestone May 3, 2021
@martinRenou
Copy link
Contributor

This should be handled by #591

@blink1073
Copy link
Member

Ah, I see, thanks @martinRenou!

@blink1073 blink1073 closed this May 3, 2021
@martinRenou
Copy link
Contributor

martinRenou commented May 3, 2021

I also think a new release in the 5.5 series is required to work with that IPython version.

I remember trying and I saw it working, so it should be fine, although maybe not the configuration. I introduced an issue that ipython/ipython#12940 fixes, but this code should not be triggered, ipykernel was already using its own configure_inline_support function IIRC.

I guess one can have a problem with an old ipykernel combined with latest IPython.

@ccordoba12
Copy link
Member Author

I remember trying and I saw it working, so it should be fine, although maybe not the configuration

It is working, I confirmed it in Spyder.

but this code should not be triggered, ipykernel was already using its own configure_inline_support function IIRC.

I don't see a problem with it being triggered for now. I mean, the problem is that the inline backend is currently semi-broken and this will fix it until ipykernel 6 is released.

@blink1073
Copy link
Member

@ccordoba12 if you can make a PR to 5.5.x I an cut a release.

@ccordoba12 ccordoba12 deleted the fix-matplotlib-inline branch May 4, 2021 15:38
@ccordoba12
Copy link
Member Author

Ok, thanks for understanding @blink1073! Will do right away.

@Carreau Carreau modified the milestones: 6.0, no action Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants