Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in %edit magic #1053

Merged
merged 2 commits into from Dec 8, 2022
Merged

Fix error in %edit magic #1053

merged 2 commits into from Dec 8, 2022

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 8, 2022

  • The problem is the _find_edit_target method is a staticmethod in IPython.
  • We have a test in Spyder for this magic, which detected that it's broken with 6.19.1.
  • This regression was introduced in Add more tests #1034, according to git blame.

@ccordoba12 ccordoba12 changed the title Fix error in edit magic Fix error in %edit magic Dec 8, 2022
@blink1073 blink1073 added the bug label Dec 8, 2022
@blink1073
Copy link
Member

@ccordoba12, you can remove the edit magic test for now. The proper fix would be to use mock.patch, I thought what I had done was a proper work-around.

@ccordoba12
Copy link
Member Author

I made a simple fix for now, just to check that it's working. Should I remove that instead?

@blink1073
Copy link
Member

I made a simple fix for now, just to check that it's working. Should I remove that instead?

That sounds good, let's keep it in. Thank you!

@blink1073 blink1073 merged commit 3c125ad into ipython:main Dec 8, 2022
@ccordoba12 ccordoba12 deleted the fix-edit-magic branch December 8, 2022 16:14
@blink1073
Copy link
Member

@ccordoba12
Copy link
Member Author

Thanks @blink1073 for your prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants