Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: too many arguments dropped when passing to base comm constructor #1051

Merged
merged 2 commits into from Dec 8, 2022
Merged

fix: too many arguments dropped when passing to base comm constructor #1051

merged 2 commits into from Dec 8, 2022

Commits on Dec 8, 2022

  1. fix: too many arguments dropped when passing to base comm constructor 

    Bug introduced in fee98e5, covered by test now.

Closes ipython#1050
    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    514495a View commit details
    Browse the repository at this point in the history

  2. simplify code 

    Co-authored-by: martinRenou <martin.renou@gmail.com>
    @maartenbreddels @martinRenou
    maartenbreddels and martinRenou committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3cf49c8 View commit details
    Browse the repository at this point in the history