DagJose JSON payload support #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
approved these changes
May 17, 2024
There was a problem hiding this comment.
I'm not deep enough into DagJose, but it sounds like it's just describing what it's doing and it sounds reasonable. Though if someone who knows more about it (@rvagg maybe?) could have a look that would be great.
So I'd appreciate one more pair of eyes, I'll approve it though in case no one else finds the time time have a look.
rvagg
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dag-jose only support payloads that are base64url encoded CIDs. This is a problem since most JOSE tools only support signing over JSON payloads. This PR extends the dag-jose codec to support arbitrary JSON payloads.