gateway: clarify entity-bytes out of range behavior #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmetic clarification based on discussion that happened in ipfs/boxo#523
lidel
changed the title
4 tasks
rvagg
reviewed
Jan 29, 2024
| @@ -155,16 +155,16 @@ The following additional values are supported: | |||
| A Gateway MUST augment the returned `Etag` based on the passed `entity-bytes`. | |||
|
|
|||
| A Gateway SHOULD return an HTTP 400 Bad Request error when the requested range | |||
| cannot be parsed as valid offset positions. | |||
| is outside of valid offset positions in full, and the gateway knows that upfront. | |||
There was a problem hiding this comment.
soft suggestion, my brain tripped up on "in full" when reading this on the first pass.
Suggested change
| is outside of valid offset positions in full, and the gateway knows that upfront. | |
| is entirely outside of the entity's byte range and the server is able to determine this | |
| upfront. |
hacdias
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies cosmetic spec clarification based on discussion that happened in ipfs/boxo#523 and was released in gateway-conformance@v0.5.
The intention here is to make it more clear that it is ok to return HTTP 200 and that truncation is fine too.
cc @rvagg @hannahhoward