IPIP-252: efficient content-routing proposal for huge IPLD trees #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momack2
reviewed
Dec 2, 2020
| @@ -0,0 +1,264 @@ | |||
| #  Content routing | |||
|
|
|||
There was a problem hiding this comment.
suggestion - start with a short recap or set of references to the status quo to orient new readers (landing on problems raises the questions "problems with what" if no background is given initially)
momack2
reviewed
Dec 2, 2020
|
|
||
| Remark: The IPFS codebase has an interface named `ContentRouting`. However, this is an interface to low-level DHT functions rather than to a wholistic content routing system as we describe here. | ||
|
|
||
| For instance, when bitswap fetches the contents of a CID, first it tries to find a provider using gossip-based queries to peering bitswap nodes and, if this fails, it tries to find a provider record in the DHT. This can be viewed as using two independent content-routing systems. Let's call them DHT-based and gossip-based, respectively. The DHT-based system has high latency and high success rate. Whereas the gossip-based system has lower-latency and lower success rate. To get the best of both, the DHT-based system is used as a fallback, should the gossip-based one fail. |
There was a problem hiding this comment.
the "respectively" is vice versa, right? peered bitswap nodes is gossip-based.
gammazero
reviewed
Dec 11, 2020
|
|
||
| ## Lack of abstraction | ||
|
|
||
| "Content routing" loosely refers to the mechanism that enables some nodes to advertise the data they have, and for other nodes to discover it, by a content identifier (CID). Currently content routing is not a unified software subsystem of IPFS, instead it is a workflow (involving using the DHT and other methods) that various applications (e.g. bitswap and graphsync) in need of content routing replicate individually and vary according to their need. |
There was a problem hiding this comment.
Suggest rewording last sentence to:
Currently content routing is not a unified software subsystem of IPFS, but is instead a workflow that uses the DHT and other methods. This workflow is replicated by various applications (e.g. bitswap and graphsync) and is varied according to the application's content routing needs.
petar
changed the title
lidel
changed the title
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.