API/Gateway listens on both IPv4 and IPv6 #9788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishi556
changed the title
|
This LGTM for new installations but existing ones will continue to use the old defaults unless there's a config migration, do you think this should include one? |
|
I think we should include one. |
|
Is there a PR with a config migration example that I can take a look at to add that into this PR? |
|
Yes |
|
Yup, hopefully I'll be able to get to it sometime this week. |
|
@Rishi556 : just checking to see if this is something you'll still be able to tackle? |
|
@BigLep I think so, just have gotten very busy and will continue to be until this weekend, but I might finally have some time after that. |
lidel
requested changes
May 23, 2023
There was a problem hiding this comment.
I am afraid this is blocked by bugs listed in #9637 (comment) – once resolved, we can get back to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.JS 18 stopped reordering DNS to have IPv4 addresses be first(nodejs/node#39987), and this causes some issues since Kubo isn't listening for API requests on [::1]. To fix this, we change the default config to listen on IPv6 and IPv4 for both api and gateway. This PR will resolve #9637.