fix(id): ascii-only identify versions #9465
Draft
+45
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/agent-version-suffix
branch
from
6357a06
to
0d30552
Compare
lidel
force-pushed
the
fix/agent-version-suffix
branch
from
0d30552
to
7384cb4
Compare
lidel
force-pushed
the
fix/agent-version-suffix
branch
2 times, most recently
from
57cb269
to
a593889
Compare
lidel
force-pushed
the
fix/agent-version-suffix
branch
from
a593889
to
2ad8bf7
Compare
|
I'm not sure I understand the motivation behind this. I'd prefer to embrace UTF-8, instead of taking extra steps to restrict ourselves to ASCII. |
Closed
|
@lidel : FYI I bumped this to 0.21 (not 0.20). Feel free to pull it in sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #9457 that ensures we trim identify versions to ASCII-only, max 64 characters.
It is applied to both values sent by Kubo, and ones read from other peers.
I also submitted libp2p/specs#491 to make this canonical behavior across implementations.