Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.9.1 #8267

Merged
merged 8 commits into from Jul 21, 2021
Merged

Release v0.9.1 #8267

merged 8 commits into from Jul 21, 2021

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Jul 16, 2021 •
edited

Waiting for review + tagging + release notes before merging

This release fixes:

@Stebalien @lidel @marten-seemann let me know if I've missed anything

Patch Release Checklist

This process handles patch releases from version vX.Y.Z to vX.Y.Z+1 assuming that vX.Y.Z is the latest released version of go-ipfs.

  • Fork a new branch (release-vX.Y.Z) from release and cherry-pick the relevant commits from master (or custom fixes) onto this branch
  • Make a minimal changelog update tracking the relevant fixes to CHANGELOG.
  • version string in version.go has been updated (in the release-vX.Y.Z+1 branch).
  • Make a PR merging release-vX.Y.Z+1 into the release branch
  • tag the merge commit in the release branch with vX.Y.Z+1
  • upload to dist.ipfs.io
    1. Build: https://github.com/ipfs/distributions#usage.
    2. Pin the resulting release.
    3. Make a PR against ipfs/distributions with the updated versions, including the new hash in the PR comment.
    4. Ask the infra team to update the DNSLink record for dist.ipfs.io to point to the new distribution.
  • cut a release on github and upload the result of the ipfs/distributions build in the previous step.
  • Announce the Release:
    • On IRC/Matrix (both #ipfs and #ipfs-dev)
    • On discuss.ipfs.io
  • Release published
  • Cut a new ipfs-desktop release
  • Merge the release branch back into master, ignoring the changes to version.go (keep the -dev version from master).

aschmahmann and others added 6 commits July 16, 2021 18:40
@aschmahmann
bump snap to build with Go 1.16
3bfc21c 
(cherry picked from commit d9f28a2)
@marten-seemann @aschmahmann
update go-libp2p to v0.14.3
4caf441 
(cherry picked from commit df70cff)
@aschmahmann
fix: downgrade mimetype dependency
d2da666 
(cherry picked from commit ffe7578)
@lidel @aschmahmann
test: gateway response for bafkqaaa
2788fde 
Context: #8230
(cherry picked from commit fcfe793)
@lidel @aschmahmann
feat: webui v2.12.4
1df585b 
(cherry picked from commit c7444fb)
@aschmahmann
chore: update deps
8684639 
(cherry picked from commit 9599ad5)
@Stebalien
Copy link
Member

That's everything I'm aware of (that's critical, at least). I'd say ship it!

marten-seemann
marten-seemann approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Optional: Include the libp2p update (#8270), which does nothing more than update go-tcp-transport.

Reminder: We need to make sure to build this with Go 1.16.6, to include the crypto/tls fix.

@aschmahmann aschmahmann mentioned this pull request Jul 20, 2021
Merged
@BigLep BigLep added this to In Review in Go IPFS Roadmap via automation Jul 20, 2021
aschmahmann
aschmahmann commented Jul 20, 2021
View reviewed changes
CHANGELOG.md
Comment on lines +3 to +12
## v0.9.1 2021-07-20

This is a small bug fix release resolving the following issues:
1. A regression where the empty CID bafkqaaa could not resolve on gateways [#8230](https://github.com/ipfs/go-ipfs/issues/8230)
2. A panic on OpenBSD [#8211](https://github.com/ipfs/go-ipfs/issues/8211)
3. High CPU usage with QUIC [#8256](https://github.com/ipfs/go-ipfs/issues/8256)
4. High memory usage with TCP [#8219](https://github.com/ipfs/go-ipfs/issues/8219)
5. Some pubsub issues ([libp2p/go-libp2p-pubsub#427](https://github.com/libp2p/go-libp2p-pubsub/pull/427), [libp2p/go-libp2p-pubsub#430](https://github.com/libp2p/go-libp2p-pubsub/pull/430))
6. Updated WebUI to [v2.12.4](https://github.com/ipfs/ipfs-webui/releases/tag/v2.12.4)
7. Fixed the snap deployment [#8212](https://github.com/ipfs/go-ipfs/pull/8212)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minimal changelog. Decided to skip the mkreleaselog steps here. Seem reasonable @Stebalien?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. (although I'd still consider including contributors).

Also note: I assume mkreleaslog is going to be pretty small.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it, it's pretty long actually because of QUIC related things. WDYT?

marten-seemann
marten-seemann reviewed Jul 20, 2021
View reviewed changes
go.mod
@@ -60,7 +60,7 @@ require (
github.com/jbenet/go-temp-err-catcher v0.1.0
github.com/jbenet/goprocess v0.1.4
github.com/libp2p/go-doh-resolver v0.3.1
github.com/libp2p/go-libp2p v0.14.2
github.com/libp2p/go-libp2p v0.14.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get v0.14.4 in (see #8267 (review)), mostly to avoid confusion later on which version we were actually running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the only thing added, aside from the TCP bump, was libp2p/go-libp2p#1115.

@Stebalien are you happy letting that into the patch release, or do you think we're better off just waiting on it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really rather not include that. I've mostly convinced myself it won't cause problems, but still.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, let's just leave it alone for now and we'll catch it in the next release

aschmahmann
aschmahmann commented Jul 21, 2021
View reviewed changes
CHANGELOG.md
Comment on lines +43 to +44
- github.com/lucas-clemente/quic-go (v0.21.1 -> v0.21.2):
- update qtls to include the crypto/tls fix of Go 1.16.6 / 1.15.14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marten-seemann the diff here is huge, is it a bug in the releaselog generator or is this basically because of how we do the qtls versioning to track different versions of Go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of LOC, the diff should be around 5 lines. In terms of commits it's huge because of the way I maintain qtls: it's basically one branch with ~40 commits, which I rebase on top of Go releases of crypto/tls every time there's a new Go release.

Really, it doesn't make a lot of sense to list those commits here, just

- update qtls to include the crypto/tls fix of Go 1.16.6 / 1.15.14

would more accurately reflect what changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be safe to say that we should generally exclude the qtls libraries from the release log since they're mostly noise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds reasonable.

@aschmahmann aschmahmann merged commit dc2715a into release Jul 21, 2021
Go IPFS Roadmap automation moved this from In Review to Done Jul 21, 2021
@BigLep BigLep moved this from Done to In Progress in Go IPFS Roadmap Jul 21, 2021
@BigLep
Copy link
Contributor

BigLep commented Jul 21, 2021

Moving back to in-progress since there is remaining work for the release.

@BigLep BigLep moved this from In Progress to Done in Go IPFS Roadmap Aug 3, 2021
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@aschmahmann
Merge pull request ipfs/kubo#8267 from ipfs/release-v0.9.1
a1059b0 
Release v0.9.1

This commit was moved from ipfs/kubo@dc2715a
@hacdias hacdias deleted the release-v0.9.1 branch May 9, 2023 11:02
@hacdias hacdias restored the release-v0.9.1 branch May 9, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@marten-seemann marten-seemann marten-seemann approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees

@aschmahmann aschmahmann

Labels
None yet
Projects
IPFS Shipyard Team
Archived in project
Go IPFS Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aschmahmann @Stebalien @BigLep @marten-seemann @lidel