Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix autonat construction #6289

Merged
merged 1 commit into from
May 2, 2019
Merged

core: fix autonat construction #6289

merged 1 commit into from
May 2, 2019

Conversation

Stebalien
Copy link
Member

License: MIT

@Stebalien
core: fix autonat construction
b57956c 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien May 1, 2019
@ghost ghost added the status/in-progress In progress label May 1, 2019
@Stebalien Stebalien requested a review from magik6k May 1, 2019 22:26
@Stebalien
Copy link
Member Author

Test issue in #6290.

magik6k
magik6k approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Was this throwing some error?
  • Are there no tests that catch that?

@sanderpick sanderpick mentioned this pull request May 2, 2019
Merged
@whyrusleeping
Copy link
Member

cough tests cough

@Stebalien
Copy link
Member Author

Was this throwing some error?

Yes.

Are there no tests that catch that?

No. I know.

@Stebalien Stebalien merged commit af8edb0 into master May 2, 2019
@Stebalien Stebalien deleted the fix/auto-nat-service branch May 2, 2019 02:22
@ghost ghost removed the status/in-progress In progress label May 2, 2019
@momack2 momack2 added this to Done in ipfs/go-ipfs May 9, 2019
@Stebalien Stebalien restored the fix/auto-nat-service branch May 30, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
No open projects
ipfs/go-ipfs
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stebalien @whyrusleeping @magik6k