Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve hostname specified with --api in http request headers #10233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Preserve hostname specified with --api in http request headers #10233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d71ed
check api addr is resolvable, but don't resolve it
softwareplumber Nov 25, 2023
b711721
update changelog
softwareplumber Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/ipfs/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@
return exe, nil
}

// Resolve the API addr.
apiAddr, err = resolveAddr(req.Context, apiAddr)
// Check that the API addr is resolvable.
_, err = resolveAddr(req.Context, apiAddr)

Check warning on line 294 in cmd/ipfs/main.go

View check run for this annotation

Codecov / codecov/patch

cmd/ipfs/main.go#L294 

Added line #L294 was not covered by tests
if err != nil {
return nil, err
}
Expand Down
3 changes: 3 additions & 0 deletions docs/changelogs/v0.25.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,7 @@ For more information see https://github.com/ipfs/kubo/pull/9747.

### 📝 Changelog

- github.com/ipfs/kubo:
- preserve specified API hostname in HTTP headers (#10205) ([ipfs/kubo#10233](https://github.com/ipfs/kubo/pull/10233))

### 👨‍👩‍👧‍👦 Contributors