Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreapi/unixfs: in /add, don't setup a MFS root with a mock #10183

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

coreapi/unixfs: in /add, don't setup a MFS root with a mock #10183

wants to merge 1 commit into from

Commits on Oct 20, 2023

  1. coreapi/unixfs: in /add, don't setup a MFS root with a mock 

    It seems to me that this section of the code is unnecessary as a similar setup would be done [in the adder](https://github.com/ipfs/kubo/blob/a7c65184976e8717ac23d7efaa5b0d477ad15deb/core/coreunix/add.go#L86-L101) already.

Additionally that would avoid using a test mock, which is questionable to begin with.
    @MichaelMure
    MichaelMure committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e8e51f2 View commit details
    Browse the repository at this point in the history