feat: path consolidation #10063
Merged
feat: path consolidation #10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hacdias
commented
Aug 11, 2023
•
hacdias
commented
- feat(path)!: consolidated path libraries boxo#334
- Update Boxo commit before merging
hacdias
force-pushed
the
path-consolidation
branch
4 times, most recently
from
5b19227
to
1542d6e
Compare
hacdias
force-pushed
the
path-consolidation
branch
2 times, most recently
from
9e7a70e
to
edbed55
Compare
hacdias
force-pushed
the
path-consolidation
branch
2 times, most recently
from
1b12387
to
ae2eb7e
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
ae2eb7e
to
48c1bcf
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
48c1bcf
to
25f873f
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
653cc94
to
25f873f
Compare
hacdias
force-pushed
the
internalize-mplex
branch
from
58fabe2
to
e5e1ae7
Compare
hacdias
force-pushed
the
path-consolidation
branch
2 times, most recently
from
3ce9189
to
bf9a3a1
Compare
hacdias
force-pushed
the
path-consolidation
branch
5 times, most recently
from
d9bca2c
to
8eb565d
Compare
4 tasks
hacdias
force-pushed
the
path-consolidation
branch
4 times, most recently
from
6338df4
to
f5b4175
Compare
hacdias
force-pushed
the
path-consolidation
branch
2 times, most recently
from
77ea675
to
4b18d58
Compare
hacdias
force-pushed
the
path-consolidation
branch
3 times, most recently
from
f78a7ee
to
21d1144
Compare
hacdias
force-pushed
the
path-consolidation
branch
3 times, most recently
from
ae8c8a1
to
b9ce207
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
297c4bb
to
9e7452e
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
9e7452e
to
8017256
Compare
crackcomm
reviewed
Nov 28, 2023
| @@ -62,13 +62,19 @@ func (s *Root) Lookup(ctx context.Context, name string) (fs.Node, error) { | |||
| return nil, syscall.Errno(syscall.ENOENT) | |||
| } | |||
|
|
|||
| p, err := path.ParsePath(name) | |||
| p, err := path.NewPath(name) | |||
There was a problem hiding this comment.
@hacdias I think this change might've broken fuse ipfs mount (ipns still works, I think):
2023-11-28T14:01:52.654+0100 DEBUG fuse/ipfs readonly/readonly_unix.go:67 fuse failed
to parse path: "QmREP1hYvkmdfHN3ybouWFaB7BenoinYRhWgcMwVWdutw4": invalid path "QmREP1hYvkmdfHN3ybo
uWFaB7BenoinYRhWgcMwVWdutw4": path does not have enough components
There was a problem hiding this comment.
It is broken beyond that though, adding /ipfs/ prefix results in:
2023-11-28T14:14:19.976+0100 DEBUG fuse/ipfs readonly/readonly_unix.go:58 Root Lookup: 'Qmde3RkqLihpS2ehi8VqUm6gZ9dCVGg4AvqGRcK5uvt78z'
2023-11-28T14:14:19.977+0100 ERROR fuse/ipfs readonly/readonly_unix.go:113 could not convert protobuf or raw node: expected protobuf dag node
There was a problem hiding this comment.
@crackcomm thanks for pinging. We are trying to take a look at it in #10243.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.