This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: use npm7 workspaces instead of lerna bootstrap #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
chore/use-npm7-workspaces
branch
from
22c7357
to
4669bc3
Compare
hugomrdias
suggested changes
Feb 23, 2021
package.json
Outdated
Comment on lines
29
to
30
| "configure-examples:add-examples-lerna": "npx json -I -f ./lerna.json -e \"this.packages.push('examples/*'); this.packages = [...new Set(this.packages)]\"", | ||
| "configure-examples:add-examples-npm": "npx json -I -f ./package.json -e \"this.workspaces.push('examples/*'); this.workspaces = [...new Set(this.workspaces)]\"", |
There was a problem hiding this comment.
if we define workspaces in the package.json we still need it in lerna.json ?
There was a problem hiding this comment.
For the time being yes - when v4.0.0 is stable we can probably get rid of it.
There was a problem hiding this comment.
Actually, I type that and lerna 4 is now tagged latest instead of next so maybe it's ready
There was a problem hiding this comment.
Though there's this: lerna/lerna#2841
achingbrain
force-pushed
the
chore/use-npm7-workspaces
branch
from
268ce03
to
162cf34
Compare
It's much faster! npm@7 is required so people will need to upgrade if they are running node 14. Node 15 comes with npm@7 so all good there. ``` npm7 real 2m30.996s user 8m11.495s sys 0m48.380sit lerna real 4m19.727s user 4m36.371s sys 0m51.310s ```
achingbrain
force-pushed
the
chore/use-npm7-workspaces
branch
from
162cf34
to
b0d686c
Compare
|
So close! Needs ipfs-examples/js-ipfs-examples#29 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much faster! npm@7 is required so people will need to upgrade
if they are running node 14. Node 15 comes with npm@7 so all good
there.