Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use gateway links to download standalone files #1945

Merged
merged 2 commits into from Jun 24, 2022

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jun 9, 2022

In #1894 we tried to address #1887. However, doing that for all types of files is blocked by ipfs/kubo#7746. This PR does the same but only for standalone files. I think it's a good improvement and can mitigate the issues that we are trying to address.

I also don't understand why the CI is failing on "Installing Dependencies" as this PR changes nothing regarding dependencies.

@hacdias hacdias requested a review from lidel June 9, 2022 12:38
@hacdias hacdias added this to In Review in Maintenance Priorities - JS via automation Jun 9, 2022
@lidel lidel temporarily deployed to Deploy June 24, 2022 13:51 Inactive
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! 👍

(CI got fixed in main branch, I updated this PR and all green now)

@lidel lidel merged commit 77c2c54 into main Jun 24, 2022
Maintenance Priorities - JS automation moved this from In Review to Done Jun 24, 2022
@lidel lidel deleted the feat/direct-download-single-file branch June 24, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants