Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an ADL to preload hamt loading #38

Merged
merged 4 commits into from
Oct 15, 2022
Merged

add an ADL to preload hamt loading #38

merged 4 commits into from
Oct 15, 2022

Conversation

willscott
Copy link
Collaborator

fix #37

this adds a unixfs-preload adl name, which will fully traverse sharded directories and files when encountered.

@willscott willscott requested a review from rvagg October 8, 2022 20:07
file/file.go Show resolved Hide resolved
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, although the lack of tests isn't exactly ideal

it would also be nice to have something in the README or some other doc that talks about "unixfs" and "unixfs-preload".

willscott and others added 2 commits October 15, 2022 13:31
Co-authored-by: Rod Vagg <rod@vagg.org>
@willscott
Copy link
Collaborator Author

added a paragraph to the readme on the difference

@willscott willscott merged commit 475ed65 into main Oct 15, 2022
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 12, 2023
add an ADL to preload hamt loading

This commit was moved from ipfs/go-unixfsnode@475ed65
@rvagg rvagg deleted the feat/preload branch February 24, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to express a selector which only walks or matches HAMTs
2 participants