feat: add non-dag codec variants (json/cbor) #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now CBOR, at least, in Filecoin when we want structured data that can't have links.
rvagg
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
ok, if we must, but I think I'd rather these consts be considered legacy and people just use https://github.com/multiformats/go-multicodec instead; it's auto generated and kept in sync with the table
|
@Stebalien do you still want this merged, or is go-multicodec fine? |
|
No, that's much better. |
|
@aschmahmann are we going to deprecate the current constants? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now CBOR, at least, in Filecoin when we want structured data that can't have links.