Remove provider query manager

[Jorropo]

Based on #535

[codecov]

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (remove-content-routing-from-bitswap-network@2dbd42a). Click here to learn what that means.

❗ Current head f3d731b differs from pull request most recent head 2e813d8. Consider uploading reports for the commit 2e813d8 to get more accurate results

@@                              Coverage Diff                               @@
##             remove-content-routing-from-bitswap-network     #536   +/-   ##
==============================================================================
  Coverage                                               ?   65.31%           
==============================================================================
  Files                                                  ?      206           
  Lines                                                  ?    25244           
  Branches                                               ?        0           
==============================================================================
  Hits                                                   ?    16488           
  Misses                                                 ?     7281           
  Partials                                               ?     1475           

Files	Coverage Δ
bitswap/bitswap.go	69.51% <ø> (ø)
bitswap/client/client.go	86.86% <100.00%> (ø)
...tswap/client/internal/messagequeue/messagequeue.go	84.92% <ø> (ø)
bitswap/network/ipfs_impl.go	78.86% <100.00%> (ø)
bitswap/options.go	44.44% <100.00%> (ø)
bitswap/server/server.go	59.75% <100.00%> (ø)
bitswap/testnet/peernet.go	38.46% <100.00%> (ø)
blockservice/test/mock.go	100.00% <100.00%> (ø)
examples/unixfs-file-cid/main.go	41.21% <100.00%> (ø)
gateway/blocks_backend.go	42.23% <ø> (ø)
... and 4 more

[Jorropo]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Remove provider query manager #536 👈
• Remove content routing from bitswap network #535
• Move providing responsabilities from bitswap to blockservice #534
• Revert blockservice sessions context #578
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Jorropo and the rest of your teammates on Graphite

[hacdias]

Can't this be done directly? AFAIK, it won't call .String unless it's indeed recording. I think it could indeed be more problematic if directly passed as a string and needed to encode it every time. But here it seems fine. Is there another reason?

[Jorropo]

It literally always call .String instantly:
https://github.com/open-telemetry/opentelemetry-go/blob/98b32a6c3a87fbee5d34c063b9096f416b250897/attribute/kv.go#L85

// Stringer creates a new key-value pair with a passed name and a string
// value generated by the passed Stringer interface.
func Stringer(k string, v fmt.Stringer) KeyValue {
	return Key(k).String(v.String())
}

[hacdias]

as on the previous stack, it looks like it does what it says, just a comment inline