Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: car-scope support #81

Merged
merged 1 commit into from Apr 6, 2023
Merged

feat: car-scope support #81

merged 1 commit into from Apr 6, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 6, 2023

This PR adds support for car-scope=block|file|all URL parameter next to the existing-but-confusing-and-only-partially-implemented depth=0|1|all, and always sends both to make Rhea debugging easier.

This will allow Saturn L1/Lassie to migrate without breaking anything during the transition.

For full context and the transition plan see #80

cc @aarshkshah1992 @willscott @hannahhoward @aschmahmann @hacdias @guanzo for visibility

This adds support for 'car-scope' URL param next to existing 'depth'
to allow Saturn L1/Lassie to migrake without breaking anything
during the transition.

Context: #80
@lidel lidel requested a review from aschmahmann April 6, 2023 18:07
@lidel lidel marked this pull request as ready for review April 6, 2023 18:07
@lidel
Copy link
Member Author

lidel commented Apr 6, 2023

As this is a cosmetic change (we still sent the old depth in addition to car-scope) I am merging it and shipping to staging later today.

@lidel lidel merged commit 0e72412 into main Apr 6, 2023
19 checks passed
@lidel lidel deleted the feat/car-scope-support branch April 6, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant