Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused CAR URL params #144

Merged
merged 2 commits into from Jun 13, 2023
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 2, 2023

This PR removes support for &depth, &car-scope and &bytes and closes #80.
Only dag-scope and entity-bytes are sent to L1s now.

Before we merge this, need sign-off that

@lidel lidel changed the title chore: remove unused url params chore: remove unused CAR URL params Jun 2, 2023
@guanzo
Copy link
Collaborator

guanzo commented Jun 2, 2023

Need to merge filecoin-saturn/nginx-car-range#29 then update and deploy L1. will report back when done

@lidel
Copy link
Member Author

lidel commented Jun 5, 2023

@guanzo did this ship? I see the linked PR was merged.

@guanzo
Copy link
Collaborator

guanzo commented Jun 5, 2023

This is shipped.

@lidel lidel merged commit d25fdc5 into main Jun 13, 2023
20 checks passed
@lidel lidel deleted the chore/remove-old-url-params branch June 13, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename ?format=car URL params to match IPIP-402
2 participants