Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use IPIP-402 param names when GRAPH_BACKEND=true #108

Merged
merged 1 commit into from May 17, 2023
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented May 16, 2023

Ref. ipfs/specs#402

This PR follows a transition plan from #80 to send all versions until every system (lassie, l1) upgrades.

follows transition plan to send all versions until every system (lassie,
l1) upgrades.
@lidel
Copy link
Member Author

lidel commented May 16, 2023

I'd like to ship this to staging, and if no issues, tag a release and ship to prod as well, to unblock other systems and allow them to safely switch to new names.

@aarshkshah1992 Depending on how HTTP cache key is built on L1 and nginx, this may temporarily produce high % of cache misses, impact latency etc. Due to this want to get 👍 from you before shipping this, in case you have any experiment running on staging.

@willscott
Copy link
Collaborator

@aarshkshah1992 is okay with this happening - ping him on slack before you deploy to staging

@aarshkshah1992
Copy link
Collaborator

@lidel "Depending on how HTTP cache key is built on L1 and nginx, this may temporarily produce high % of cache misses, impact latency etc."

Could you elaborate more on this. Do we have a mitigation plan in place if this does indeed happen i.e. how do we then improve the latency, cache hit percentage etc ? Will we have to roll back the change or do some work on Saturn ?

@lidel
Copy link
Member Author

lidel commented May 17, 2023

If Saturn treats URL query and path as opaque string, and used that as cache key, we need to wait for Saturn cache to fill up with the new URLs, and things will get back to normal.

Just warning the metrics may be skewed for a few hours or a day.

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to see if I understand what's happening here: we're adding support for IPIP-0402 parameters on the parameters we pass to the backend, right? The gateway itself does not support them but will after we have ipfs/boxo#303. If that is the case, I would rename the PR.

@lidel lidel changed the title feat: support IPIP-402 refactor: use IPIP-402 param names when GRAPH_BACKEND=true May 17, 2023
@lidel lidel merged commit f9df8a0 into main May 17, 2023
17 checks passed
@lidel lidel deleted the ipip-402 branch May 17, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants