chore: Update libipld to 0.15 #40
Conversation
|
I left this separate from #41 but could close this and included in the PR referenced here. |
| libp2p = { version = "0.49.0", features = ["tcp", "noise", "yamux", "rsa", "async-std"] } | ||
| multihash = { version = "0.16.1", default-features = false, features = ["blake3"] } | ||
| multihash = { version = "0.17", default-features = false, features = ["blake3"] } |
There was a problem hiding this comment.
I’d prefer to stay in sync with libp2p on this one, which is still on 0.16.1.
There was a problem hiding this comment.
Would have to double check, I believe this change was done for was due to the test using the reexport of Code from libipld while also using MultihashDigest from multihash itself, which caused it to failed so I bumped it up to match libipld
There was a problem hiding this comment.
just saw libp2p/rust-libp2p#3196, so we can do this now
| @@ -29,7 +29,7 @@ unsigned-varint = { version = "0.7.1", features = ["futures", "std"] } | |||
| [dev-dependencies] | |||
| async-std = { version = "1.10.0", features = ["attributes"] } | |||
| env_logger = "0.9.0" | |||
| libipld = { version = "0.14.0", default-features = false, features = ["dag-cbor"] } | |||
| libipld = { version = "0.15.0", default-features = false, features = ["dag-cbor"] } | |||
There was a problem hiding this comment.
This will require many other crates to upgrade as well. Are there reasons to make this urgent? Otherwise I’d have postponed this to the next libp2p upgrade.
There was a problem hiding this comment.
I am using libipld 0.15 which applies this fix and because of using a newer version, libp2p-bitswap would give a compiler error due to the use of StoreParams from a newer version (which might fall back to a previous comment made in #39). If you wish to postpone, I can use a fork with this upgrade for the time being until it is updated here
There was a problem hiding this comment.
Right, those compilation errors are what then forces the upgrade dance on all my repos … we can merge this now but I’d like to hold back with releasing until libp2p 0.51 is out.
There was a problem hiding this comment.
Waiting until libp2p 0.51 is fine with me.
|
Okay, we agree — I’ll close this and do the trivial version updates on |
|
done in 7dd9cec (which includes a fix for the |
This updates libipld to 0.15 (as well as the dev dependency of multihash to 0.17)