Reject BPF programs with jump targets outside of range of instructions. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
changed the title
hawkinsw
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
I think that this is 100% a-okay. It might make sense for a future PR to add an additional check after JIT (if that happens). That additional check after JIT would ensure that the calls in any generated code are valid as well. A boot-and-suspenders type of check?
Alan-Jowett
added a commit
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
pushed a commit
to Alan-Jowett/ebpf-for-windows
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
github-merge-queue bot
pushed a commit
to microsoft/ebpf-for-windows
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a crucial change to the
validatefunction in thevm/ubpf_vm.cfile. The condition checking thecall_targetvariable has been updated to prevent out-of-bounds access. Previously, the condition allowed forcall_targetto be equal tonum_insts, which could potentially lead to accessing an element beyond the array's limit. Now, the condition has been corrected tocall_target >= num_insts, ensuring thatcall_targetstays within the valid range of array indices.Resolves: #431