Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable retpoline on Windows by default until fixed #321

Merged
merged 2 commits into from Jul 26, 2023

Conversation

Alan-Jowett
Copy link
Collaborator

Disable retpoline code on Windows until #320 is fixed.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Copy link
Collaborator

@hawkinsw hawkinsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick Q.

@@ -26,13 +26,7 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")

target_compile_options("ubpf_settings" INTERFACE
-g
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MARK (see below)

vm/ubpf_config.h.inc Show resolved Hide resolved
@Alan-Jowett Alan-Jowett enabled auto-merge (squash) July 25, 2023 21:22
@hawkinsw hawkinsw self-requested a review July 25, 2023 22:10
@Alan-Jowett Alan-Jowett merged commit 9bcda2f into iovisor:main Jul 26, 2023
30 of 34 checks passed
@Alan-Jowett Alan-Jowett deleted the disable_retpoline_windows branch July 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants