Add support for custom data relocation #170
Conversation
Alan-Jowett
force-pushed
the
issue45
branch
8 times, most recently
from
aeb7357
to
7cf1297
Compare
Alan-Jowett
changed the title
|
Marking this as ready for review. Codecov.io is having an outage, so coverage upload is currently failing. |
|
I am more than happy to adjust the PR and shepherd it through final preparation if that would help you in any way, @Alan-Jowett !! Just let me know if/how I can help! |
|
Hello @Alan-Jowett -- I don't mean to bother you but I wanted to see if there was anything that I could do to help! Just let me know if I can! |
|
@hawkinsw Thanks for reviewing this. I will try to set aside some time and update this PR sometime this week. |
Please don't worry! I just wanted offer help if I can! |
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <atjowet@gmail.com>
Signed-off-by: Alan Jowett <atjowet@gmail.com>
|
@hawkinsw if the changes look good, could you marked the review as approved? As long as I get at least 1 reviewer, I am willing to merge this. |
| uint64_t size = sym.st_size; | ||
| uint64_t imm = | ||
| vm->data_relocation_function(vm->data_relocation_user_data, data, size, sym_name, sym.st_value); | ||
| inst->imm = (uint32_t)imm; |
There was a problem hiding this comment.
Just wanted to confirm: It looks like you are passing the size of the symbol here and not the size of the section. (see above).
|
|
||
| /** | ||
| * @brief Data relocation function that is called by the VM when it encounters a | ||
| * R_BPF_64_64 relocation in the maps section of the ELF file. |
There was a problem hiding this comment.
Do we want to be this specific in the documentation? It may be that the use case is completely orthogonal to maps. For instance, what I am using it for is independent of maps (it just targets some data). (see below)
|
@Alan-Jowett See #260 -- I hope it helps!! Thank you so much for letting me work on this project with you! |
Pull request was closed
Adding support for R_BPF_64_64 relocations via custom callback.
Resolves: #45
Resolves: #54
With this change, uBPF can be used with an external map implementation.
Signed-off-by: Alan Jowett alanjo@microsoft.com