Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

fix(desktop): Update to Electron 7.2.3 #2742

Merged
merged 10 commits into from May 3, 2020
Merged

fix(desktop): Update to Electron 7.2.3 #2742

merged 10 commits into from May 3, 2020

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Apr 22, 2020 •
edited

Description of change

Updates to Electron 7.2.3

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

  • Tested on macOS
  • Tested on Windows
  • Tested on Ubuntu

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working T - Enhancement New feature or request C - Desktop E - Security Epic - Security related labels Apr 22, 2020
@rajivshah3 rajivshah3 closed this Apr 22, 2020
@rajivshah3 rajivshah3 reopened this Apr 22, 2020
@rajivshah3 rajivshah3 added the L - WIP Lifecycle - Work in Progress label Apr 22, 2020
@rajivshah3 rajivshah3 removed the L - WIP Lifecycle - Work in Progress label Apr 22, 2020
@rajivshah3 rajivshah3 marked this pull request as ready for review April 23, 2020 01:05
@rajivshah3 rajivshah3 added this to In progress in Trinity via automation Apr 23, 2020
@rajivshah3 rajivshah3 moved this from In progress to Review needed in Trinity Apr 23, 2020
@rajivshah3 rajivshah3 mentioned this pull request Apr 23, 2020
Closed
@rajivshah3 rajivshah3 mentioned this pull request Apr 28, 2020
Merged
Trinity automation moved this from Review needed to Reviewer approved Apr 28, 2020
@laumair
Copy link
Contributor

laumair commented Apr 28, 2020

It looks like getName() is deprecated. Perhaps we should update it here, here and here.

@rajivshah3
Copy link
Member Author

rajivshah3 commented Apr 28, 2020 •
edited

Good catch, I forgot to check where that warning was coming from. I'll update it to app.name

@rajivshah3
fix(desktop): Replace app.getName() with app.name
bd7654d 
app.getName() is now deprecated
@rajivshah3
Copy link
Member Author

It looks like getName() is deprecated. Perhaps we should update it here, here and here.

Resolved in bd7654d

laumair
laumair approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@laumair laumair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rajivshah3 rajivshah3 merged commit 78a8b2a into develop May 3, 2020
Trinity automation moved this from Reviewer approved to Done May 3, 2020
@rajivshah3 rajivshah3 deleted the chore/electron-7 branch May 3, 2020 16:48
@rajivshah3 rajivshah3 mentioned this pull request May 5, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laumair laumair laumair approved these changes

@nothingismagick nothingismagick nothingismagick approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees
No one assigned
Labels
C - Desktop E - Security Epic - Security related T - Bug Type - Bug: Something isn't working T - Enhancement New feature or request
Projects
Trinity
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajivshah3 @laumair @nothingismagick