New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Wasm Stardust bindings #967
Conversation
WasmStateMetadataEncoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this!
.wasm_result() | ||
} | ||
|
||
// TODO: unpack_from_output/unpackFromOutput ? Feature-gated method, do we need an equivalent? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since unpack can do the job for now, I suggest keeping the todo for now, and we can add it in the future if needed.
…r/identity.rs into feat/wasm-stardust
Changes from #965 are fine. My bad, I missed that review request. |
Description of change
Add initial Wasm bindings for the IOTA UTXO/Stardust DID Method.
Added
WasmStardustDID
.WasmStardustDIDUrl
.WasmStardustDocument
.WasmStardustDocumentMetadata
.WasmStardustService
.WasmStardustVerificationMethod
.WasmDocumentMetadata.properties()
.WasmDocument.setMetadataPropertyUnchecked()
.WasmDID.METHOD
.WasmDID.DEFAULT_NETWORK
.IIotaService
interface which extendsIService
.Changed
WasmDocumentMetadata.previousMessageId
to not be a getter, for consistency.WasmDID.join()
to borrow and clone internally.IService
TypeScript interface to excludeid
.Removed
parking_lot
dependency andwasm-bindgen
feature, which was deprecated; enable the "wasm-bindgen" feature forinstant
directly instead. Added a custom lint tolints.js
to catch future breakages.Links to any relevant issues
Sub-task of #908.
Type of change
How the change has been tested
Added
stardust.ts
unit tests. The new lint can be tested by commenting out theinstant
dependency inCargo.toml
and executingnpm run build
, which will fail with the lint error.Change checklist