Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iota-client version to 1.1 #525

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Dec 6, 2021

Description of change

Hot fix for a compilation error on the main branch reported in #524 due to the iota-client git dependency being updated.
Bumps the iota-client version to 1.1 from crates.io.

This is the same fix performed for the dev branch in #503. There should be no functional changes from applying this patch.

Edit: bumps identity to 0.4.1

Links to any relevant issues

Fixes issue #524

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tests and examples pass locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Dec 6, 2021
@cycraig cycraig linked an issue Dec 6, 2021 that may be closed by this pull request
@cycraig
Copy link
Contributor Author

cycraig commented Dec 6, 2021

Audit check fails due to serde_cbor (#518) which is only a dev-dependency, the chrono crate (#442) and the time crate (#440) which we are also not really vulnerable to given the particular steps for it to occur.

Edit: and every other check is failing due to the new Clippy lints introduced in Rust 1.57...

@cycraig cycraig changed the title Hot fix iota-client version to 1.1 Bump iota-client version to 1.1 Dec 6, 2021
@JelleMillenaar JelleMillenaar merged commit 4f46bf6 into main Dec 6, 2021
@JelleMillenaar JelleMillenaar deleted the fix/iota-client-dependency branch December 6, 2021 09:01
@cycraig cycraig added the No changelog Excludes PR from becoming part of any changelog label Dec 15, 2021
eike-hass pushed a commit that referenced this pull request Dec 17, 2021
* Bump iota-client dependency to 1.1

* Fix clippy lints

* Bump identity to 0.4.1
@cycraig cycraig added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog and removed No changelog Excludes PR from becoming part of any changelog labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compiling error on main branch
3 participants