-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chrono
#784
Merged
thibault-martinez
merged 9 commits into
iotaledger:dev
from
Adam-Gleave:dev-remove-chrono
Oct 21, 2021
Merged
Remove chrono
#784
thibault-martinez
merged 9 commits into
iotaledger:dev
from
Adam-Gleave:dev-remove-chrono
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-Gleave
requested review from
Alex6323,
samuel-rufi and
thibault-martinez
as code owners
October 19, 2021 12:54
Adding to #786. |
thibault-martinez
requested changes
Oct 21, 2021
thibault-martinez
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Removes the
chrono
crate.I have also created a new
time
module inbee-common
for getting local time and creating formatted strings, since the same code is used in a couple of different places.Links to any relevant issues
#783 and #779.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Run the node to ensure timestamps format correctly. The output shows as:
This is in the correct local time to me (UTC +1).
Change checklist