Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chrono #784

Merged
merged 9 commits into from
Oct 21, 2021
Merged

Remove chrono #784

merged 9 commits into from
Oct 21, 2021

Conversation

Adam-Gleave
Copy link
Contributor

Description of change

Removes the chrono crate.

I have also created a new time module in bee-common for getting local time and creating formatted strings, since the same code is used in a couple of different places.

Links to any relevant issues

#783 and #779.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Run the node to ensure timestamps format correctly. The output shows as:

2021-10-19 13:18:54 bee_protocol::workers::message::payload    INFO  Running.

This is in the correct local time to me (UTC +1).

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@Adam-Gleave
Copy link
Contributor Author

Adding to #786.

bee-common/bee-common/src/logger/mod.rs Outdated Show resolved Hide resolved
bee-common/bee-common/src/time.rs Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez merged commit 453ec95 into iotaledger:dev Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants