fix: server column 'type' as 'ENTERPRISE'/'CUBE', not 'server' #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avirtopeanu-ionos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
cristiGuranIonos,
adeatcu-ionos,
glimberea and
cbeti-ionos
and removed request for
a team
avirtopeanu-ionos
force-pushed
the
test/volume
branch
2 times, most recently
from
c1c283d
to
b597870
Compare
cbeti-ionos
approved these changes
May 16, 2024
avirtopeanu-ionos
force-pushed
the
test/volume
branch
from
3a3ac4b
to
8b0432c
Compare
avirtopeanu-ionos
force-pushed
the
fix/volume-todos
branch
from
0b28819
to
c1ecbae
Compare
avirtopeanu-ionos
force-pushed
the
test/volume
branch
2 times, most recently
from
244a59d
to
013e24c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the column path mapping to display the actual server's type ('CUBE'/'ENTERPRISE'), not the CloudAPI resource type ('server'). Adds a test for this.
The other TODO was wrong, the completions work fine, but just need
--datacenter-idset, this could be treated separately as an improvement to handle all images if that flag isn't set.