feat(scheduler): support optional cpu constraints and make sort by guest count optional #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamcore
force-pushed
the
feat/scheduler/cpu
branch
from
eed199b
to
d73b246
Compare
|
Thanks for your PR, We will check this. |
pborn-ionos
force-pushed
the
feat/scheduler/cpu
branch
from
d73b246
to
907a291
Compare
mcbenjemaa
reviewed
Jan 22, 2024
| @@ -78,6 +78,15 @@ type SchedulerHints struct { | |||
| // By default 100% of a node's memory will be used for allocation. | |||
| // +optional | |||
| MemoryAdjustment *uint64 `json:"memoryAdjustment,omitempty"` | |||
|
|
|||
| // Like MemoryAdjustment, but for CPU resources. | |||
There was a problem hiding this comment.
Please write a meaningful description here.
Re-explain the adjustment term here as well.
| // +optional | ||
| CPUAdjustment *uint64 `json:"cpuAdjustment,omitempty"` | ||
|
|
||
| // +optional |
There was a problem hiding this comment.
Here we also need a description and why this is needed.
| requested uint64 | ||
| // InsufficientResourcesError is used when the scheduler cannot assign a VM to a node because no node | ||
| // would be able to provide the requested resources. | ||
| type InsufficientResourcesError struct { |
There was a problem hiding this comment.
I guess its better to separate the error by CPU, Memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optionally allows the scheduler to take CPU cores into account, as well as disabling the sorting by guest count. I think with this it should be relatively simple, to, for example, include a host's actual cpu load as well.