馃敟 Add external credentials #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbenjemaa
requested review from
65278,
avorima,
lubedacht and
pborn-ionos
as code owners
wikkyk
reviewed
May 28, 2024
lubedacht
reviewed
May 29, 2024
api/v1alpha1/proxmoxcluster_types.go
Outdated
| // CredentialsRef is a reference to a Secret that contains the credentials to use for provisioning this cluster. If not | ||
| // supplied then the credentials of the controller will be used. | ||
| // +optional | ||
| CredentialsRef *corev1.ObjectReference `json:"credentialsRef,omitempty"` |
There was a problem hiding this comment.
Maybe SecretReference or if you expect the secret to be in the same namespace LocalObjectReference would be sufficient?
There was a problem hiding this comment.
SecretReference is okay,
mcbenjemaa
force-pushed
the
external-creds
branch
from
c97859d
to
64c2870
Compare
wikkyk
requested changes
Jun 3, 2024
|
Please check the added docs. |
|
wikkyk
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds external credentials to the Cluster.
To make it able to use multiple Proxmox data centers
Close #210