Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipv4config error in example cluster-class #209

Merged
merged 1 commit into from
May 27, 2024

Conversation

isZumpo
Copy link
Contributor

@isZumpo isZumpo commented May 12, 2024

Was getting

.spec.ipv4Config: expected map, got &{[10.10.10.10-10.10.10.20]}

Assuming it is because of this recent commit which did some changes to the cluster-class example.

Removes the .addresses from the patching configuration. With these changes the validation error no longer occurs on my setup.

Was getting .spec.ipv4Config: expected map, got &{[10.10.10.10-10.10.10.20]}" without this change.
Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@mcbenjemaa mcbenjemaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@65278 please check

Copy link
Collaborator

@65278 65278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I forgot to refactor that one. Sorry about that.
LGTM.

@65278 65278 added this to the v0.5.0 milestone May 24, 2024
@mcbenjemaa mcbenjemaa merged commit b1f4614 into ionos-cloud:main May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants