bump go to 1.22 #188
Open
bump go to 1.22 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wikkyk
requested review from
65278,
avorima,
lubedacht,
pborn-ionos and
mcbenjemaa
as code owners
|
obsoletes #190 |
|
I will squash this PR into a single commit because none of commits in the PR work without all the other commits in the PR. |
|
@mcbenjemaa you need to be more specific - in what way are they not working? |
|
sorry, my caches |
wikkyk
added
dependencies
|
We've decided against merging this until a cluster-api release with controller-runtime v0.18.0 support comes out. |
|
None of the providers moved to 1.22
I recommend that we wait for the v1.8 release. To be compliant with CAPI. |
This was referenced May 29, 2024
|
capi 1.7.2 still does not support controller-runtime 0.18 |
Plus relevant dependency updates. fix #187
|
Rebased for v0.5.0. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #187
+mass dep update:
k8s/api* to 0.30
controller-gen to 0.15.0 (0.14.0 has the go 1.22 panic fix)
controller-runtime to 0.18.0 (dependency)
Regenerated crds using new controller-gen. Note config/rbac/role.yaml and config/webhook/manifest.yaml.