Add custom tags to machines #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
avorima
reviewed
Apr 4, 2024
| tags = append(tags, tag) | ||
| } | ||
| } | ||
| if len(tags) > length { |
There was a problem hiding this comment.
this check does not account for removal of tags. is this intended?
There was a problem hiding this comment.
Yes, so we don't delete existing tags.
The IP tag i mean.
Which means tags are also immutable as per the machine.
There was a problem hiding this comment.
then you need to add this to the webhook or a CRD kubebuilder annotation
| @@ -131,3 +144,14 @@ func validateNetworkDeviceMTU(device *infrav1.NetworkDevice) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func validateTags(tags []string) error { | |||
| re := regexp.MustCompile(`^[a-zA-Z0-9-_]*$`) | |||
There was a problem hiding this comment.
Should be + not * to prevent empty string. Also, have you tried +kubebuilder:validation:Pattern?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Tags