Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go to 1.22 #187

Open
wikkyk opened this issue Apr 25, 2024 · 4 comments · May be fixed by #188
Open

bump go to 1.22 #187

wikkyk opened this issue Apr 25, 2024 · 4 comments · May be fixed by #188
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@wikkyk
Copy link
Collaborator

wikkyk commented Apr 25, 2024

Needed by #183 #186

@wikkyk wikkyk added the dependencies Pull requests that update a dependency file label Apr 25, 2024
@wikkyk wikkyk added this to the v0.5.0 milestone Apr 25, 2024
@wikkyk wikkyk changed the title bump go to 1.33 bump go to 1.22 Apr 25, 2024
wikkyk added a commit that referenced this issue Apr 25, 2024
@wikkyk wikkyk linked a pull request Apr 25, 2024 that will close this issue
wikkyk added a commit that referenced this issue Apr 25, 2024
@SimonKienzler
Copy link

Hi 👋🏻 I just tried to set up development on the current main and had problems running make generate using go 1.22.1. controller-gen panics in version v0.11.3 when used with this version of go. See kubernetes-sigs/controller-tools#880

Bumping to v0.14.0 solved the issue for me.

wikkyk added a commit that referenced this issue Apr 25, 2024
@wikkyk
Copy link
Collaborator Author

wikkyk commented Apr 25, 2024

@SimonKienzler we're aware but thanks for reminding me :)

wikkyk added a commit that referenced this issue Apr 29, 2024
wikkyk added a commit that referenced this issue Apr 30, 2024
@wikkyk wikkyk modified the milestones: v0.5.0, v0.6.0 May 31, 2024
@wikkyk
Copy link
Collaborator Author

wikkyk commented May 31, 2024

postponed until v0.6.

wikkyk added a commit that referenced this issue Jun 7, 2024
wikkyk added a commit that referenced this issue Jun 7, 2024
wikkyk added a commit that referenced this issue Jun 7, 2024
Plus relevant dependency updates.

fix #187
@wikkyk
Copy link
Collaborator Author

wikkyk commented Jun 7, 2024

https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/releases/release-1.8.md
It's likely we'll need to postpone this until CAPI 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants