Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): when multiple gradle operations on the same file, only t… #183

Merged
merged 1 commit into from
May 8, 2023

Conversation

ngandon
Copy link
Contributor

@ngandon ngandon commented Apr 25, 2023

When multiple operation on the same gradle file, fix the issue where only the first operation was taken into account

#182

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trapeze ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 0:06am

@Crylion
Copy link
Contributor

Crylion commented May 5, 2023

Can you elaborate on what this fixes for you?
If I understand your changes correctly, it basically reuses the fetched gradle file for later entries instead of fetching it again for every instruction, but the end result should be the same. For each entry, the gradle file gets fetched, and the instruction is processed. With your code it is definitely more efficient, but otherwise the functionality stays the same, no?

@mlynch mlynch merged commit c7e7be4 into ionic-team:main May 8, 2023
2 checks passed
@ngandon
Copy link
Contributor Author

ngandon commented May 9, 2023

Hello @Crylion,

Indeed it seems like the functionality would stay the same.
However, when fetching the gradle file for each entry, only the first update was registered in the end. I didn't check exactly why, but fetching the gradle multiple time was overwriting the changes.

And thanks for the merge

@mlynch
Copy link
Contributor

mlynch commented May 9, 2023

This is live in @trapezedev/configure@next, mind testing it @ngandon and make sure it's working for your needs? Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants