fix for

feat(e2e): add support for puppteer v19 #3810
ionic-team · Dec 2, 2022 · b5e3cc6 · b5e3cc6
1 parent d3ce762
commit b5e3cc6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/src/sys/node/node-sys.ts b/src/sys/node/node-sys.ts
@@ -607,8 +607,8 @@ export function createNodeSys(c: { process?: any } = {}): CompilerSystem {
     '@types/jest': { minVersion: '24.9.1', recommendedVersion: '27.0.3', maxVersion: '27.0.0' },
     jest: { minVersion: '24.9.1', recommendedVersion: '27.0.3', maxVersion: '27.0.0' },
     'jest-cli': { minVersion: '24.9.0', recommendedVersion: '27.4.5', maxVersion: '27.0.0' },
-    puppeteer: { minVersion: '1.19.0', recommendedVersion: '10.0.0' },
-    'puppeteer-core': { minVersion: '1.19.0', recommendedVersion: '5.2.1' },
+    puppeteer: { minVersion: '10.0.0', recommendedVersion: '19' },
+    'puppeteer-core': { minVersion: '10.0.0', recommendedVersion: '19' },
     'workbox-build': { minVersion: '4.3.1', recommendedVersion: '4.3.1' },
   });
 

diff --git a/src/testing/puppeteer/puppeteer-element.ts b/src/testing/puppeteer/puppeteer-element.ts
@@ -467,17 +467,13 @@ export class E2EElement extends MockHTMLElement implements pd.E2EElementInternal
   }
 
   async e2eSync() {
-    const executionContext = this._elmHandle.executionContext();
-
-    const { outerHTML, shadowRootHTML } = await executionContext.evaluate<{ outerHTML: any; shadowRootHTML: any }>(
-      (elm: HTMLElement) => {
-        return {
-          outerHTML: elm.outerHTML,
-          shadowRootHTML: elm.shadowRoot ? elm.shadowRoot.innerHTML : null,
-        };
-      },
-      this._elmHandle
-    );
+    const executionContext = getPuppeteerExecution(this._elmHandle);
+    const { outerHTML, shadowRootHTML } = await executionContext.evaluate((elm: Element) => {
+      return {
+        outerHTML: elm.outerHTML,
+        shadowRootHTML: elm.shadowRoot ? elm.shadowRoot.innerHTML : null,
+      };
+    }, this._elmHandle);
 
     if (typeof shadowRootHTML === 'string') {
       (this as any).shadowRoot = parseHtmlToFragment(shadowRootHTML) as any;