New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(puppeteer): update support table #932
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810
76e1175
to
812ca47
Compare
this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed one thing
src/docs/reference/support-policy.md
Outdated
| V3 | ❌ | ✅ | ✅ | ✅ | ✅ | | ||
| V2 | ✅ | ✅ | ❌ | ❌ | ❌ | | ||
| V1 | ✅ | ❌ | ❌ | ❌ | ❌ | | ||
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer 19 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've got a little inconsistency here, if we want to stick with what we've been doing maybe this?
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer 19 | | |
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer v19 | |
or we could change them all to Puppeteer 5-9
, Puppeteer 10
, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alicewriteswrongs I added 'v' in d5f3cea and fixed up the table alignment as a result in that same commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810 this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810 this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810 this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810 this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810 this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
this commit updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810 this commit updates the puppeteer section of the breaking_changes document to clarify the version of puppeteer that is supported
this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
this commit also updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810