Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(puppeteer): update support table #932

Merged
merged 3 commits into from Nov 30, 2022

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Nov 10, 2022

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported

this commit also updates the support table for puppeteer versions for stencil v3. it serves as the documentation for ionic-team/stencil#3810

Screen Shot 2022-11-10 at 4 38 13 PM

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stencil-site ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 8:17PM (UTC)

this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810
this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed one thing

| V3 | ❌ | ✅ | ✅ | ✅ | ✅ |
| V2 | ✅ | ✅ | ❌ | ❌ | ❌ |
| V1 | ✅ | ❌ | ❌ | ❌ | ❌ |
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer 19 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got a little inconsistency here, if we want to stick with what we've been doing maybe this?

Suggested change
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer 19 |
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer v19 |

or we could change them all to Puppeteer 5-9, Puppeteer 10, etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicewriteswrongs I added 'v' in d5f3cea and fixed up the table alignment as a result in that same commit

Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwaskiewicz rwaskiewicz merged commit e33f4de into v3.0.0-dev Nov 30, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/puppeteer19-support branch November 30, 2022 12:49
rwaskiewicz added a commit that referenced this pull request Jan 20, 2023
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
rwaskiewicz added a commit that referenced this pull request Jan 23, 2023
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
rwaskiewicz added a commit that referenced this pull request Jan 25, 2023
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
rwaskiewicz added a commit that referenced this pull request Jan 25, 2023
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
rwaskiewicz added a commit that referenced this pull request Jan 25, 2023
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
rwaskiewicz added a commit that referenced this pull request Jan 25, 2023
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants