Visual warts #25

russok · 2019-08-09T23:04:08Z

added 100% height to the wrapper DIV to avoid truncation of content (same as issue Wrong height property on about/login pages in demo app #12)
isAuthenticated is used as if it means the opposite (same as issue Inverted menu items #24)
Tutorial menu item is disabled for no reason: added the route to tutorial
The label "Enter your support message below" is truncated: reads as "Enter your support me..."

… tutorial

russok · 2019-08-09T23:22:43Z

src/components/Menu.tsx

        </IonList>
        <IonList>
          <IonListHeader>Tutorial</IonListHeader>
-          <IonItem onClick={() => {}}>


the handler like that disables the item

russok · 2019-08-09T23:23:51Z

src/components/Menu.tsx

  function renderlistItems(list: any[]) {
    return list
-      .filter(route => !!route.path)


all paths are truthy, no need for filtering

russok added 3 commits August 9, 2019 15:07

when side-by-side, the label is truncated

2c82e52

isAuthenticated is used as if it means the opposite; add the route to…

64a5cb4

… tutorial

added full height to the wrapper div to avoid trunction of content

c81957d

russok commented Aug 9, 2019

View reviewed changes

Provide feedback