ionic-team · brandyscarney · May 10, 2024 · May 9, 2024 · May 10, 2024 · May 10, 2024
diff --git a/core/scripts/docker.mjs b/core/scripts/docker.mjs
@@ -53,4 +53,7 @@ if (requestHeaded && !hasHeadedConfigFiles) {
   console.warn(chalk.yellow.bold('\n⚠️ You are running tests in headed mode, but one or more of your headed config files was not found.\nPlease ensure that both docker-display.txt and docker-display-volume.txt have been created in the correct location.\n'));
 }
 
-execa('docker', args, { shell: true, stdio: 'inherit' });
+const res = await execa('docker', args, { shell: true, stdio: 'inherit' });
+
+// If underlying scripts failed this whole process should fail too
+process.exit(res.exitCode);
@@ -2,7 +2,7 @@
 <html lang="en" dir="ltr">
   <head>
     <meta charset="UTF-8" />
-    <title>Accordion - Basic</title>
+    <title>Accordion - Standalone</title>
     <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
     <link href="../../../../../css/ionic.bundle.css" rel="stylesheet" />
     <link href="../../../../../scripts/testing/styles.css" rel="stylesheet" />
@@ -119,6 +119,7 @@ <h2>Margins In Content</h2>
       outline: none;
       text-align: left;
       padding: 20px 16px;
+      color: black;
     }
 
     .custom-accordion-content {

@@ -11,7 +11,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, screenshot, t
       test('should update the active item', async ({ page }) => {
         const breadcrumbItems = page.locator('ion-breadcrumb');
 
-        const addItemButton = page.locator('ion-button#add-btn');
+        const addItemButton = page.locator('#add-btn');
 
         await expect(breadcrumbItems).toHaveCount(4);
 

@@ -7,7 +7,7 @@ configs().forEach(({ title, screenshot, config }) => {
       await page.goto('/src/components/datetime/test/position', config);
       const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent');
 
-      const openDateTimeBtn = page.locator('ion-button#open-datetime');
+      const openDateTimeBtn = page.locator('#open-datetime');
       await openDateTimeBtn.click();
 
       await ionPopoverDidPresent.next();

@@ -74,7 +74,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c
 
       await ionLoadingDidPresent.next();
 
-      const button = page.locator('ion-loading ion-button');
+      const button = page.locator('ion-loading button');
 
       if (browserName === 'webkit') {
         await page.keyboard.down('Alt');

@@ -18,7 +18,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
 
     test.describe('pushing a new page', () => {
       test('should render the pushed component', async ({ page }) => {
-        const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")');
+        const pageTwoButton = page.locator('button:has-text("Go to Page Two")');
         const pageOne = page.locator('page-one');
         const pageTwo = page.locator('page-two');
 
@@ -32,7 +32,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
       });
 
       test('should render the back button', async ({ page }) => {
-        const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")');
+        const pageTwoButton = page.locator('button:has-text("Go to Page Two")');
         const pageTwoBackButton = page.locator('page-two ion-back-button');
 
         await pageTwoButton.click();
@@ -45,7 +45,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
     test('back button should pop to the previous page', async ({ page }) => {
       const pageOne = page.locator('page-one');
       const pageTwo = page.locator('page-two');
-      const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")');
+      const pageTwoButton = page.locator('button:has-text("Go to Page Two")');
       const pageTwoBackButton = page.locator('page-two ion-back-button');
 
       await pageTwoButton.click();
@@ -65,8 +65,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
         const pageTwo = page.locator('page-two');
         const pageThree = page.locator('page-three');
 
-        const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")');
-        const pageThreeButton = page.locator('ion-button:has-text("Go to Page Three")');
+        const pageTwoButton = page.locator('button:has-text("Go to Page Two")');
+        const pageThreeButton = page.locator('button:has-text("Go to Page Three")');
 
         await pageTwoButton.click();
         await page.waitForChanges();

@@ -16,8 +16,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
       const pageOne = page.locator('page-one');
       const pageTwo = page.locator('page-two');
 
-      const pageTwoButton = page.locator('ion-button:has-text("Go to Page 2")');
-      const pageTwoTwoButton = page.locator('ion-button:has-text("Go to Page 2.2")');
+      const pageTwoButton = page.locator('button:has-text("Go to Page 2")');
+      const pageTwoTwoButton = page.locator('button:has-text("Go to Page 2.2")');
 
       await pageTwoButton.click();
       await page.waitForChanges();
@@ -35,7 +35,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
       await expect(pageTwoOne).toHaveCount(1);
       await expect(pageTwoTwo).toBeVisible();
 
-      const pageThreeButton = page.locator('ion-button:has-text("Go to Page 3")');
+      const pageThreeButton = page.locator('button:has-text("Go to Page 3")');
 
       await pageThreeButton.click();
       await page.waitForChanges();
@@ -49,8 +49,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
 
     test.describe('back button', () => {
       test('should work with nested ion-nav', async ({ page }) => {
-        const pageTwoButton = page.locator('ion-button:has-text("Go to Page 2")');
-        const pageTwoTwoButton = page.locator('ion-button:has-text("Go to Page 2.2")');
+        const pageTwoButton = page.locator('button:has-text("Go to Page 2")');
+        const pageTwoTwoButton = page.locator('button:has-text("Go to Page 2.2")');
 
         await pageTwoButton.click();
         await page.waitForChanges();
@@ -61,7 +61,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
         await pageTwoTwoButton.click();
         await page.waitForChanges();
 
-        const pageThreeButton = page.locator('ion-button:has-text("Go to Page 3")');
+        const pageThreeButton = page.locator('button:has-text("Go to Page 3")');
         const pageThreeBackButton = page.locator('page-three ion-back-button');
 
         await pageThreeButton.click();

@@ -24,8 +24,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
         const pageOne = page.locator('page-one');
         const pageTwo = page.locator('page-two');
 
-        const pageOneButton = page.locator('ion-button:has-text("Go to Page One")');
-        const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")');
+        const pageOneButton = page.locator('button:has-text("Go to Page One")');
+        const pageTwoButton = page.locator('button:has-text("Go to Page Two")');
 
         await pageOneButton.click();
         await page.waitForChanges();
@@ -45,7 +45,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
       });
 
       test('should render the back button', async ({ page }) => {
-        const pageOneButton = page.locator('ion-button:has-text("Go to Page One")');
+        const pageOneButton = page.locator('button:has-text("Go to Page One")');
         const pageOneBackButton = page.locator('page-one ion-back-button');
 
         await pageOneButton.click();
@@ -59,7 +59,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
       const pageRoot = page.locator('page-root');
       const pageOne = page.locator('page-one');
 
-      const pageOneButton = page.locator('ion-button:has-text("Go to Page One")');
+      const pageOneButton = page.locator('button:has-text("Go to Page One")');
       const pageOneBackButton = page.locator('page-one ion-back-button');
 
       await pageOneButton.click();
@@ -80,9 +80,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
         const pageTwo = page.locator('page-two');
         const pageThree = page.locator('page-three');
 
-        const pageOneButton = page.locator('ion-button:has-text("Go to Page One")');
-        const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")');
-        const pageThreeButton = page.locator('ion-button:has-text("Go to Page Three")');
+        const pageOneButton = page.locator('button:has-text("Go to Page One")');
+        const pageTwoButton = page.locator('button:has-text("Go to Page Two")');
+        const pageThreeButton = page.locator('button:has-text("Go to Page Three")');
 
         await pageOneButton.click();
         await page.waitForChanges();