chore(tests): harmonize Jest package version to address test file matching #26320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
changed the title
sean-perkins
approved these changes
Nov 18, 2022
alicewriteswrongs
force-pushed
the
ap/test-jest-cli-stuff
branch
from
75989d3
to
982331c
Compare
|
no prob, always happy to help! and just updated the commit message to follow that convention. |
…ching This harmonizes the versions of Jest installed in Framework to address an issue reported in Stencil here: ionic-team/stencil#3785 The issue is essentially that certain test commands, such as this one: ``` npx stencil test --spec --max-workers=2 src/utils/keyboard/test/ ``` will, at present, alternate between running the tests as expected and failing. Not good! The issue is caused by having different versions of `@jest/core`, on the one hand, and `jest` and `jest-cli` on the other. After updating `jest` and `jest-cli` to match the version of `@jest/core` (`27.5.1`) and the issue can no longer be reproduced.
alicewriteswrongs
force-pushed
the
ap/test-jest-cli-stuff
branch
from
982331c
to
6441778
Compare
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This harmonizes the versions of Jest installed in Framework to address an issue reported in Stencil here:
ionic-team/stencil#3785
The issue is essentially that certain test commands, such as this one:
will, at present, alternate between running the tests as expected and failing. Not good!
The issue is caused by having different versions of
@jest/core, on the one hand, andjestandjest-clion the other. After updatingjestandjest-clito match the version of@jest/core(27.5.1) and the issue can no longer be reproduced.Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: ionic-team/stencil#3785
What is the new behavior?
The commands reported as failing in the Stencil issue above no longer fail!
Does this introduce a breaking change?
Other information