Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): fix encoding issue in multipart/form-data requests #7219

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

rezendeneto
Copy link

@rezendeneto rezendeneto commented Jan 26, 2024

This PR addresses the issue of handling special characters in FormData requests (e.g. ü, ö, and ä). To provide a clearer understanding of the changes, I've prepared a code snippet, which you can view here: tutorialspoint snippet

@rezendeneto
Copy link
Author

rezendeneto commented Feb 23, 2024

Hello! Can we please get a review on this PR?

This PR contains a minor code change that fixes the issue where a FormData can't be submitted with "special" characters like ö, ü and ä.

@rezendeneto rezendeneto changed the title fix(http): fix encoding issue in FormData requests fix(http): fix encoding issue in multipart/form-data requests Feb 26, 2024
@JosefBredereck
Copy link

Does this also resolve the issue if the file name contains any of these special characters?

@rezendeneto
Copy link
Author

@JosefBredereck good point! Since we know that os.writeBytes does not handle well special characters, I would assume that, if they appear in any of these calls, they wouldn't be encoded correctly:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants