Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onUpdateVisitedHistory callback #6857 #6858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add onUpdateVisitedHistory callback #6857 #6858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 15 additions & 4 deletions android/capacitor/src/main/java/com/getcapacitor/BridgeWebViewClient.java
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ public void onPageFinished(WebView view, String url) {
List<WebViewListener> webViewListeners = bridge.getWebViewListeners();

if (webViewListeners != null && view.getProgress() == 100) {
for (WebViewListener listener : bridge.getWebViewListeners()) {
for (WebViewListener listener : webViewListeners) {
listener.onPageLoaded(view);
}
}
Expand All @@ -52,7 +52,7 @@ public void onReceivedError(WebView view, WebResourceRequest request, WebResourc

List<WebViewListener> webViewListeners = bridge.getWebViewListeners();
if (webViewListeners != null) {
for (WebViewListener listener : bridge.getWebViewListeners()) {
for (WebViewListener listener : webViewListeners) {
listener.onReceivedError(view);
}
}
Expand All @@ -70,7 +70,7 @@ public void onPageStarted(WebView view, String url, Bitmap favicon) {
List<WebViewListener> webViewListeners = bridge.getWebViewListeners();

if (webViewListeners != null) {
for (WebViewListener listener : bridge.getWebViewListeners()) {
for (WebViewListener listener : webViewListeners) {
listener.onPageStarted(view);
}
}
Expand All @@ -82,7 +82,7 @@ public void onReceivedHttpError(WebView view, WebResourceRequest request, WebRes

List<WebViewListener> webViewListeners = bridge.getWebViewListeners();
if (webViewListeners != null) {
for (WebViewListener listener : bridge.getWebViewListeners()) {
for (WebViewListener listener : webViewListeners) {
listener.onReceivedHttpError(view);
}
}
Expand All @@ -92,4 +92,15 @@ public void onReceivedHttpError(WebView view, WebResourceRequest request, WebRes
view.loadUrl(errorPath);
}
}

@Override
public void doUpdateVisitedHistory(WebView view, String url, boolean isReload) {
super.doUpdateVisitedHistory(view, url, isReload);
List<WebViewListener> webViewListeners = bridge.getWebViewListeners();
if (webViewListeners != null) {
for (WebViewListener listener : webViewListeners) {
listener.onUpdateVisitedHistory(view.canGoBack());
}
}
}
}
10 changes: 10 additions & 0 deletions android/capacitor/src/main/java/com/getcapacitor/WebViewListener.java
View file
Open in desktop
Expand Up @@ -42,4 +42,14 @@ public void onReceivedHttpError(WebView webView) {
public void onPageStarted(WebView webView) {
// Override me to add behavior to the page started event
}

/**
* Callback for page-visit changes that should lead to the user having different browsing state
* and history.
*
* @param canGoBack Whether or not the user can go further back in the visit history
*/
public void onUpdateVisitedHistory(boolean canGoBack) {
// Override me to add behavior to the page-visit history update
}
}