feat: promise with callback plugin method #5622
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5618
Allows to add a callback function to a plugin method which returns a promise. Calling
call.resolve()
on keep alive passes the object to the callback - when a callback was provided. Setting keep alive to false passes the object to the promise and resolves it.call.reject()
rejects the promise and deletes the saved callback.This should not be a breaking change to the value return method type when no callback function is provided to the method or keep alive is never set to true.
Android example usage
Platform(s)